Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22049 )
Change subject: WIP IMPALA-10319: Support arbitrary encodings on Text/Sequence files ...................................................................... Patch Set 18: (7 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py File tests/query_test/test_charcodec.py: http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@22 PS18, Line 22: from tests.util.filesystem_utils import WAREHOUSE flake8: F401 'tests.util.filesystem_utils.WAREHOUSE' imported but unused http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@29 PS18, Line 29: u flake8: F821 undefined name 'unichr' http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@48 PS18, Line 48: def _generate_random_word(charset, min_length=1, max_length=20): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@52 PS18, Line 52: def _compare_tables(selfobj, db, utf8_table, encoded_table): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@66 PS18, Line 66: class TestCharCodecGen(ImpalaTestSuite): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@251 PS18, Line 251: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22049/18/tests/query_test/test_charcodec.py@251 PS18, Line 251: #################################################################### line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22049 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I787cd01caa52a19d6645519a6cedabe0a5253a65 Gerrit-Change-Number: 22049 Gerrit-PatchSet: 18 Gerrit-Owner: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Mihaly Szjatinya <msz...@pm.me> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Sun, 27 Apr 2025 12:00:25 +0000 Gerrit-HasComments: Yes
