Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22289 )
Change subject: IMPALA-12927: Support specifying format for reading JSON BINARY columns ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/22289/10/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22289/10/be/src/service/query-options.cc@1346 PS10, Line 1346: break; Thanks for spotting and fixing this! I think that it should be ideally merged in an addendum commit to simplify backporting (added a comment to IMPALA-13657 about this) Can you create one? For example: IMPALA-13657: (Addendum) Add missing break in query-options.cc I can also do this if you don't have time. -- To view, visit http://gerrit.cloudera.org:8080/22289 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idf61fa3afc0f33caa63fbc05393e975733165e82 Gerrit-Change-Number: 22289 Gerrit-PatchSet: 10 Gerrit-Owner: Zihao Ye <eyiz...@163.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zihao Ye <eyiz...@163.com> Gerrit-Comment-Date: Sun, 27 Apr 2025 08:56:25 +0000 Gerrit-HasComments: Yes
