Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22807 )
Change subject: IMPALA-13989: Invalidate table on rename failure ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22807/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22807/5//COMMIT_MSG@22 PS5, Line 22: Adds concurrency tests with : simultaneous rename and invalidate metadata that previously would fail. : > It happened pretty regularly in test_concurrent_ddls. I'm working on making Using INVALIDATE METADATA <table> on the old table name might be easlier since it's faster than gloabl INVALIDATE METADATA. http://gerrit.cloudera.org:8080/#/c/22807/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22807/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5752 PS7, Line 5752: The HMS alter_table event has already been picked up by a global invalidate nit: This is just one possibility. A concurrent INVALIDATE <table> could also lead to this. http://gerrit.cloudera.org:8080/#/c/22807/7/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@5759 PS7, Line 5759: } Can we add a warning if version <= 0? E.g. "Deletion update on the old table {} not found. Impalad might still have its metadata until the deletion update arrives from statestore." -- To view, visit http://gerrit.cloudera.org:8080/22807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic2a276b6e5ceb35b7f3ce788cc47052387ae8980 Gerrit-Change-Number: 22807 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 26 Apr 2025 09:58:24 +0000 Gerrit-HasComments: Yes
