Joe McDonnell has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22821
Change subject: IMPALA-13978: Remove gutil's gscoped_ptr/bind/callback functionality ...................................................................... IMPALA-13978: Remove gutil's gscoped_ptr/bind/callback functionality gutil's gscoped_ptr/bind/callback provide functionality that was introduced in C++11. It has been obsolete for a long time and is barely used in the codebase. Kudu removed this code from their gutils quite a while ago: https://github.com/apache/kudu/commit/4f7b1aaf88 This replaces gscoped_ptr/gscoped_array with std::unique_ptr (matching Kudu's modifications for gutil). This removes gutil's bind/callback/move, as they are now unused. Testing: - Ran precommit Change-Id: I2ec79f32fb281f2bceeaed3e2fcbc75ae75308bd --- M be/src/exec/kudu/kudu-scan-node.cc M be/src/exec/kudu/kudu-scan-node.h M be/src/exec/kudu/kudu-scanner.cc M be/src/exec/kudu/kudu-table-sink.cc M be/src/gutil/CMakeLists.txt D be/src/gutil/bind.h D be/src/gutil/bind.h.pump D be/src/gutil/bind_helpers.h D be/src/gutil/bind_internal.h D be/src/gutil/bind_internal.h.pump D be/src/gutil/callback.h D be/src/gutil/callback.h.pump D be/src/gutil/callback_forward.h D be/src/gutil/callback_internal.cc D be/src/gutil/callback_internal.h D be/src/gutil/gscoped_ptr.h D be/src/gutil/move.h M be/src/gutil/stl_util.h M be/src/gutil/strings/escaping.cc M be/src/gutil/strings/join.cc M be/src/gutil/strings/strcat.cc M be/src/rpc/impala-service-pool.cc M be/src/rpc/impala-service-pool.h M be/src/runtime/buffered-tuple-stream-test.cc M be/src/util/hdr-histogram.h 25 files changed, 36 insertions(+), 6,939 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/22821/1 -- To view, visit http://gerrit.cloudera.org:8080/22821 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: I2ec79f32fb281f2bceeaed3e2fcbc75ae75308bd Gerrit-Change-Number: 22821 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
