Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22815 )
Change subject: IMPALA-13991: Skip CROSS_JOIN rewrite if subquery is in disjunctive ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/22815/4/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java File fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java: http://gerrit.cloudera.org:8080/#/c/22815/4/fe/src/main/java/org/apache/impala/analysis/StmtRewriter.java@29 PS4, Line 29: import org.apache.impala.planner.CardinalityCheckNode; Why was this needed? http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test File testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/nested-loop-join.test@344 PS4, Line 344: | join predicates: timestamp_col < timestamp_col This description seems strange; would it match anything? http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test: http://gerrit.cloudera.org:8080/#/c/22815/4/testdata/workloads/functional-planner/queries/PlannerTest/subquery-rewrite.test@4112 PS4, Line 4112: where (t.int_col = 0 or Is there some reason to replace the test case rather than adding a new one? -- To view, visit http://gerrit.cloudera.org:8080/22815 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iac0deb0b2fb1536684cce2e004156a20b769b9ab Gerrit-Change-Number: 22815 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 20:28:38 +0000 Gerrit-HasComments: Yes
