Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22793 )
Change subject: IMPALA-13829: Fix waitForHmsEvent response might miss deletions ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22793/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22793/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4422 PS1, Line 4422: // Send back the last catalog version that has been propagated to statestore. : // Coordinators can wait for that in case some deletions are missing due to deleteLog : // being GCed. : res.result.setVersion(lastSentTopicUpdate_.get()); > Good catch! Proposed another patch as a quick fix by postponding the GC: https://gerrit.cloudera.org/c/22816/ -- To view, visit http://gerrit.cloudera.org:8080/22793 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3ff7bc4d8b47d2aabec0f1fe73a3ab39e8e407cb Gerrit-Change-Number: 22793 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 25 Apr 2025 03:12:00 +0000 Gerrit-HasComments: Yes
