Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22802 )
Change subject: IMPALA-13631: (Addendum) Retry aborted concurrent DDLs ...................................................................... IMPALA-13631: (Addendum) Retry aborted concurrent DDLs TestConcurrentDdls has several exceptions it considers acceptable for testing; it would accept the query failure and continue with other cases. That was fine for existing queries, but if an ALTER RENAME fails subsequent queries will also fail because the table does not have the expected name. With IMPALA-13631, there are three exception cases we need to handle: 1. "Table/view rename succeeded in the Hive Metastore, but failed in Impala's Catalog Server" happens when the HMS alter_table RPC succeeds but local catalog has changed. INVALIDATE METADATA on the target table is sufficient to bring things in sync. 2. "CatalogException: Table ... was modified while operation was in progress, aborting execution" can safely be retried. 3. "Couldn't retrieve the catalog topic update for the SYNC_DDL operation" happens when SYNC_DDL=1 and the DDL runs on a stale table object that's removed from the cache by a global INVALIDATE. Adds --max_wait_time_for_sync_ddl_s=10 in catalogd_args for the last exception to occur. Otherwise the query will just timeout. Tested by running test_concurrent_ddls.py 15 times. The 1st exception previously would show up within 3-4 runs, while the 2nd exception happens pretty much every run. Change-Id: I04d071b62e4f306466a69ebd9e134a37d4327b77 Reviewed-on: http://gerrit.cloudera.org:8080/22802 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Michael Smith <michael.sm...@cloudera.com> --- M tests/custom_cluster/test_concurrent_ddls.py 1 file changed, 50 insertions(+), 17 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Michael Smith: Verified -- To view, visit http://gerrit.cloudera.org:8080/22802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I04d071b62e4f306466a69ebd9e134a37d4327b77 Gerrit-Change-Number: 22802 Gerrit-PatchSet: 5 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
