Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22640 )
Change subject: IMPALA-13850 (part 2): Implement in-place reset for CatalogD ...................................................................... Patch Set 22: (3 comments) http://gerrit.cloudera.org:8080/#/c/22640/22/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java: http://gerrit.cloudera.org:8080/#/c/22640/22/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@514 PS22, Line 514: logSkip > nit: This variable name indicates that we should skip logging info if set t I'll just switch the boolean var name to skipLog and change the caller parameter instead. http://gerrit.cloudera.org:8080/#/c/22640/22/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2520 PS22, Line 2520: while (!resettingDbs_.isEmpty()) { > How do we get out of this while loop without polling the entries? If it is not empty, we'll arrive at resetMetadataCondition_.await() below. Next time this loop is waken up, check resettingDbs_ state again, and return if it is empty. http://gerrit.cloudera.org:8080/#/c/22640/22/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/22640/22/tests/custom_cluster/test_concurrent_ddls.py@89 PS22, Line 89: def test_local_catalog_ddls_with_invalidate_metadata_unlock_gap(self, unique_database): > Can this patch overcome a hypothetical scenario where Alter table rename is That will be tricky. I guess I can add waitOngoingResetMetadata overload that should wait until both Dbs are free. Do you know what other Catalog operation that mutate more than 1 Db at the same time? -- To view, visit http://gerrit.cloudera.org:8080/22640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d Gerrit-Change-Number: 22640 Gerrit-PatchSet: 22 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Apr 2025 20:12:29 +0000 Gerrit-HasComments: Yes
