Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22802 )
Change subject: IMPALA-13631: (Addendum) Retry aborted concurrent DDLs ...................................................................... Patch Set 2: (1 comment) Added back the expected error message of SYNC_DDL=1 and slightly refactored the patch. http://gerrit.cloudera.org:8080/#/c/22802/1/tests/custom_cluster/test_concurrent_ddls.py File tests/custom_cluster/test_concurrent_ddls.py: http://gerrit.cloudera.org:8080/#/c/22802/1/tests/custom_cluster/test_concurrent_ddls.py@a168 PS1, Line 168: : : : > I think this issue still exists. The reason that the stale message doesn't I can still reproduce IMPALA-9135. One difference after IMPALA-6671 is that the query keeps hanging instead of throwing such an error due to topic_update_tbl_max_wait_time_ms is 120000 and max_wait_time_for_sync_ddl_s is 0 by default. So CatalogServiceCatalog#shouldTimeOut() always returns false. private boolean shouldTimeOut(long numAttempts, long maxNumAttempts, long startTime) { int timeoutSecs = BackendConfig.INSTANCE.getMaxWaitTimeForSyncDdlSecs(); if (topicUpdateTblLockMaxWaitTimeMs_ > 0) { if (timeoutSecs <= 0) return false; // <---- always return here return (System.currentTimeMillis() - startTime) > timeoutSecs * 1000L; } else { return numAttempts > maxNumAttempts; } } https://github.com/apache/impala/blob/fb789df3be7cfbbae519248de6437aa87bad0963/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java#L3657 Modified the tests to set a non-zero max_wait_time_for_sync_ddl_s. -- To view, visit http://gerrit.cloudera.org:8080/22802 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I04d071b62e4f306466a69ebd9e134a37d4327b77 Gerrit-Change-Number: 22802 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 23 Apr 2025 12:01:54 +0000 Gerrit-HasComments: Yes
