Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22718 )
Change subject: IMPALA-13923: Support more compression levels for ZSTD and ZLIB ...................................................................... Patch Set 3: (2 comments) > Joe McDonnell > 12:29 AM > Patch Set 8: > Michael Smith > Apr 22 10:21 PM > Patch Set 6: Thanks a lot for the quick suggestions. http://gerrit.cloudera.org:8080/#/c/22718/3/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/22718/3/be/src/util/compress.h@48 PS3, Line 48: int compression_level = Z_DEFAULT_COMPRESSION); > We can proceed without this, but I think the code would be cleaner if we di I have removed the default initialization logic from codec.cc now. To make it even cleaner, I can make optional<int> compression_level part of Codec and then inherit them in compressor too. But, this still creates problems with validating compression levels externally from parse-util, we would need to instantiate a Codec/Compressor first to validate levels. So, I have kept the ValidateCompressionLevel method as it is. Please do let me know, if there are other ways around even this. http://gerrit.cloudera.org:8080/#/c/22718/3/be/src/util/compress.h@66 PS3, Line 66: int compression_level_; > We can leave it on the individual compressors for now. Right now, different Done -- To view, visit http://gerrit.cloudera.org:8080/22718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b98c735246f08e04598a4e752c8cca04e31a88a Gerrit-Change-Number: 22718 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Apr 2025 20:33:05 +0000 Gerrit-HasComments: Yes
