Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22799 )
Change subject: IMPALA-13824: add unit tests for PlanToJson ...................................................................... Patch Set 1: (5 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler-test.cc File be/src/service/impala-http-handler-test.cc: http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler-test.cc@194 PS1, Line 194: const vector<string> ImpalaHttpHandlerTest::selectLabels = { "01:EXCHANGE", "00:SCAN HDFS"}; line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler-test.cc@195 PS1, Line 195: const vector<string> ImpalaHttpHandlerTest::selectLabelDetails = { "UNPARTITIONED", "default.table"}; line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler-test.cc@204 PS1, Line 204: addNodeToFragment(&fragment1, &summary, selectLabels.at(0), selectLabelDetails.at(0), 0); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler-test.cc@205 PS1, Line 205: addNodeToFragment(&fragment2, &summary, selectLabels.at(1), selectLabelDetails.at(1), 0); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/22799/1/be/src/service/impala-http-handler.cc@1151 PS1, Line 1151: void impala::PlanToJson(const vector<TPlanFragment>& fragments, const TExecSummary& summary, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22799 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1b7f2b3a914c9091db51fbed117a80330f1d6fe5 Gerrit-Change-Number: 22799 Gerrit-PatchSet: 1 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Tue, 22 Apr 2025 08:58:35 +0000 Gerrit-HasComments: Yes
