Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22789 )
Change subject: IMPALA-13631: alterTableOrViewRename shouldn't hold catalog versionLock during external RPCs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22789/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22789/1//COMMIT_MSG@21 PS1, Line 21: However, : that doesn't mean we need the lock before operating the cache in : CatalogServiceCatalog.renameTable(). We actually acquires the lock again : in this method. So no need to keep holding the lock when invoking HMS : RPCs. > nit: Please clarify in commit message that holding table lock is enough for We don't need the catalog lock when making RPCs to HMS. We acquire the catalog lock in CatalogServiceCatalog#renameTable before updating the catalog, which I think is the relevant point. -- To view, visit http://gerrit.cloudera.org:8080/22789 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie5f443b1e167d96024b717ce70ca542d7930cb4b Gerrit-Change-Number: 22789 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 21 Apr 2025 22:01:30 +0000 Gerrit-HasComments: Yes
