Anonymous Coward (801) has posted comments on this change. ( http://gerrit.cloudera.org:8080/21170 )
Change subject: Resolve linker errors due to mising ImpalaUdf library ...................................................................... Patch Set 4: (4 comments) Some minor fixes suggested. http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h File udf-sample.h: http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@75 PS4, Line 75: // symbol=ClassifyReviewsDefault'; I believe the opening ' character is missing for 'ClassifyReviewsDefault'. http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.h@84 PS4, Line 84: // symbol=ClassifyReviews'; I believe the opening ' character is missing for 'ClassifyReviews'. http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc File udf-sample.cc: http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@167 PS4, Line 167: const StringVal api_key_jceks_secret("open-ai-key"); I believe this parameter should be ai_api_key_jceks_secret http://gerrit.cloudera.org:8080/#/c/21170/4/udf-sample.cc@171 PS4, Line 171: context, endpoint, prompt, model, api_key_jceks_secret, params, options); api_key_jceks_secret should be ai_api_key_jceks_secret -- To view, visit http://gerrit.cloudera.org:8080/21170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: impala-udf-samples Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I703398294dd719818352d5070297a2f74decdeed Gerrit-Change-Number: 21170 Gerrit-PatchSet: 4 Gerrit-Owner: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (801) Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 23:51:23 +0000 Gerrit-HasComments: Yes
