Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22792 )
Change subject: WIP: IMPALA-13911: Support ipv6 in internal Thrift interfaces ...................................................................... Patch Set 1: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/rpc/thrift-util.cc File be/src/rpc/thrift-util.cc: http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/rpc/thrift-util.cc@247 PS1, Line 247: Status status = WaitForServer("localhost", server.port(), num_retries, retry_interval_ms); line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/runtime/exec-env.cc File be/src/runtime/exec-env.cc: http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/runtime/exec-env.cc@277 PS1, Line 277: string statestore_subscriber_hostname = !FLAGS_statestore_subscriber_interface.empty() ? line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/runtime/exec-env.cc@277 PS1, Line 277: string statestore_subscriber_hostname = !FLAGS_statestore_subscriber_interface.empty() ? line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22792/1/be/src/runtime/exec-env.cc@299 PS1, Line 299: string subscriber_id = Substitute("impalad@$0:$1", statestore_subscriber_hostname, FLAGS_krpc_port); line too long (102 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I20d3361aeaebd55d571bd0127bd9334911b587e1 Gerrit-Change-Number: 22792 Gerrit-PatchSet: 1 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 17 Apr 2025 19:39:00 +0000 Gerrit-HasComments: Yes
