Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22775 )
Change subject: IMPALA-13958: Revisit hs2_parquet_constraint and hs2_text_constraint ...................................................................... Patch Set 3: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/22775/3/tests/query_test/test_decimal_queries.py File tests/query_test/test_decimal_queries.py: http://gerrit.cloudera.org:8080/#/c/22775/3/tests/query_test/test_decimal_queries.py@50 PS3, Line 50: or v.get_value('table_format').file_format in ['parquet', 'orc', 'kudu', 'json']) nit: This alignment looks odd. Is this auto-formatted? I would expect "v.get_value", "and" and "or" to line up. http://gerrit.cloudera.org:8080/#/c/22775/3/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/22775/3/tests/query_test/test_queries.py@270 PS3, Line 270: # Infinity, NaN, false, and true. HS2 returns inf, nan, False, and True instead. I assume we'll have to address this in another ticket? -- To view, visit http://gerrit.cloudera.org:8080/22775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8be0a628842e29a8fcc036180654cd159f6a23c8 Gerrit-Change-Number: 22775 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 22:43:01 +0000 Gerrit-HasComments: Yes
