Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22743 )
Change subject: IMPALA-13936: REFRESH should wait for ALTER ownership events ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/22743/4/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22743/4/fe/src/main/java/org/apache/impala/service/Frontend.java@81 PS4, Line 81: import org.apache.impala.analysis.CreateUdfStmt; removed unused imports http://gerrit.cloudera.org:8080/#/c/22743/4/fe/src/main/java/org/apache/impala/service/Frontend.java@2264 PS4, Line 2264: // single > Why are we changing from Set to Collection? It is possible to have duplicat Replied in https://gerrit.cloudera.org/c/22571/8/fe/src/main/java/org/apache/impala/service/Frontend.java#2244 but you might miss it. At L2276, it can be a singleton list for SIngleTableStmt. Only one item in the list for this case so no needs for deduplication. At L2280, it's still a set to deduplicate table names. Note that List and Set are both Collection in Java. -- To view, visit http://gerrit.cloudera.org:8080/22743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I813007e9ec42392d0f6d3996331987c138cc4fb8 Gerrit-Change-Number: 22743 Gerrit-PatchSet: 5 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 05:46:54 +0000 Gerrit-HasComments: Yes
