Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850 (part 1): Wait until CatalogD active before resetting ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/22634/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22634/15//COMMIT_MSG@24 PS15, Line 24: : The later prerequisite is to ensure that all coordinators are not : blocked waiting for full topic update in on-demand metadata mode. This : is all manage > typo: It will be a bad experience LGTM. Do we have test coverage for this? I.e. if we don't restore it in patch set 16, will some tests fail? http://gerrit.cloudera.org:8080/#/c/22634/16/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22634/16/be/src/catalog/catalog-server.cc@717 PS16, Line 717: if (FLAGS_catalogd_ha_reset_metadata_on_failover) { : triggered_first_reset_ = false; : } Can we move this below to L724, or it should be done before regenerating the catalog service id and clearing the pending topic updates? http://gerrit.cloudera.org:8080/#/c/22634/16/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/22634/16/tests/common/impala_cluster.py@566 PS16, Line 566: # noqa: U100 Why do we need this "noqa" comment? -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Apr 2025 09:29:42 +0000 Gerrit-HasComments: Yes
