Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22743 )
Change subject: IMPALA-13936: REFRESH should wait for ALTER ownership events ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/22743/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22743/2//COMMIT_MSG@14 PS2, Line 14: s, > nit: Thus, Done http://gerrit.cloudera.org:8080/#/c/22743/2//COMMIT_MSG@14 PS2, Line 14: what the table is. T > nit: what the table is Done http://gerrit.cloudera.org:8080/#/c/22743/2/fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java File fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java: http://gerrit.cloudera.org:8080/#/c/22743/2/fe/src/main/java/org/apache/impala/analysis/SingleTableStmt.java@24 PS2, Line 24: / > Annotate with @Nullable Done http://gerrit.cloudera.org:8080/#/c/22743/2/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22743/2/fe/src/main/java/org/apache/impala/service/Frontend.java@2265 PS2, Line 2265: Handle SingleTableStmt such as CREA > nit: SingleTableStmt such as REFRESH/INVALIDATE METADATA <table> Only REFRESH/INVALIDATE METADATA <table> has this issue. Other kinds of SingleTableStmt such as DROP TABLE are able to return table names in collectTableRefs(): https://github.com/apache/impala/blob/50a98dce46fd337461f67b98979fece95c7bf738/fe/src/main/java/org/apache/impala/analysis/DropTableOrViewStmt.java#L93 Updated the comment to better explaining the code. -- To view, visit http://gerrit.cloudera.org:8080/22743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I813007e9ec42392d0f6d3996331987c138cc4fb8 Gerrit-Change-Number: 22743 Gerrit-PatchSet: 3 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Tue, 15 Apr 2025 01:31:33 +0000 Gerrit-HasComments: Yes
