Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22780 )
Change subject: IMPALA-13746: Fix long ldap password handling in impala-shell+hs2-http ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22780/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22780/1//COMMIT_MSG@14 PS1, Line 14: Based on impyla fix https://github.com/cloudera/impyla/pull/562 by : https://github.com/paulmayer nit: mention that his fix exist in Impyla 0.21a3 http://gerrit.cloudera.org:8080/#/c/22780/1/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java File fe/src/test/java/org/apache/impala/testutil/LdapUtil.java: http://gerrit.cloudera.org:8080/#/c/22780/1/fe/src/test/java/org/apache/impala/testutil/LdapUtil.java@44 PS1, Line 44: public static final String TEST_PASSWORD_LONG = : "verylongpasswordthatcreatesalongbasic64encodin"; What is the maximum limit for this? Is this the maximum? http://gerrit.cloudera.org:8080/#/c/22780/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22780/1/shell/impala_client.py@436 PS1, Line 436: user_passwd = "{0}:{1}".format(self.user, self.ldap_password) : # Produce RFC 2617-compliant basic credentials: : # - RFC 2045 encoding of username:password without limitations to 76 chars : # per line (and without trailing newline) : # - No translation of characters (+,/) for URL-safety : auth = base64.b64encode(user_passwd.encode()).decode() This remove sys.version_info.major < 3 check. Is this change valid regardless of python version? I'm surprised there is no modified tests in tests/shell/. Should we have one, with create_impala_shell_executable_dimension in it? -- To view, visit http://gerrit.cloudera.org:8080/22780 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4d73d682cf2d1843d9801ef71b99d551b79deb19 Gerrit-Change-Number: 22780 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Mon, 14 Apr 2025 16:09:09 +0000 Gerrit-HasComments: Yes
