Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 33: (1 comment) http://gerrit.cloudera.org:8080/#/c/22319/33/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/22319/33/common/thrift/Query.thrift@778 PS33, Line 778: // See comment in ImpalaService.thrift : 192: optional bool use_calcite_planner = false; > The list of planners along with an implied precedence order makes sense, al We mainly care about fallback for testing purposes. I think end users shouldn't be configuring fallback themselves. I'd like to hide that complexity if I can. I would like the main configuration option to be simple. Either a boolean for whether Calcite is enabled or something like a DEFAULT_SQL_COMPILER as either "calcite" or "classic". I think the boolean is good, unless we think there will be a third option some day. (I hope there isn't a third option.) Fallback is something that we can configure through a separate option. At the moment, there are only two fallback modes that we need. One falls back for every error. The other falls back only for non-query statements and lets queries fail. I don't know if it will eventually get more complicated. -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 33 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Mon, 07 Apr 2025 19:45:04 +0000 Gerrit-HasComments: Yes
