Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/22731 )
Change subject: IMPALA-13930: ImpylaHS2Connection should only open cursor as needed ...................................................................... Patch Set 6: Code-Review+1 (2 comments) Thanks for taking care of this Riza! I left 2 minor comments. I do not have any other suggestion. http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@9 PS6, Line 9: ImpylaHS2Connection open a cursor (and HS2 session) as it connect, : followed by running a "SET ALL" query to populate the default query : options. Could we slightly change this paragraph to the following so that it would be clear as to what ImpylaHS2Connection behaved before this patch? Before this patch, ImpylaHS2Connection unconditionally opened a cursor (and HS2 session) as it connected, followed by running a "SET ALL" query to populate the default query options. http://gerrit.cloudera.org:8080/#/c/22731/6//COMMIT_MSG@20 PS6, Line 20: Fix test_query_profile_contains_query_compilation_metadata_cached_event : slightly by setting the 'sync_ddl' option because the test is flaky : without it. It's just for my own understanding. Nothing has to be changed here. Does 'test_query_profile_contains_query_compilation_metadata_cached_event' become flaky because of this patch? Or you just deflaked the test along with the changes to how default query options are collected? -- To view, visit http://gerrit.cloudera.org:8080/22731 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d5e3e5c11ad386b7202431201d1a4cff46cbff5 Gerrit-Change-Number: 22731 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 21:55:45 +0000 Gerrit-HasComments: Yes
