Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22761 )
Change subject: IMPALA-13932: Add file path and position-based duplicate check for IcebergMergeNode ...................................................................... IMPALA-13932: Add file path and position-based duplicate check for IcebergMergeNode IcebergMergeNode's duplicate checking mechanism was based on comparing pointers of the target table's rows. This mechanism results in false positives if a new row batch reused the memory of the previous row batch provided for the merge node. This change adds an additional check that validates the file position and file path as well. Change-Id: I71b47414321675958c05438ef3aeeb5df0128033 Reviewed-on: http://gerrit.cloudera.org:8080/22761 Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Reviewed-by: Zoltan Borok-Nagy <borokna...@cloudera.com> --- M be/src/exec/iceberg-merge-node.cc M be/src/exec/iceberg-merge-node.h M fe/src/main/java/org/apache/impala/analysis/IcebergMergeImpl.java M testdata/workloads/functional-planner/queries/PlannerTest/iceberg-merge-insert-only.test 4 files changed, 72 insertions(+), 30 deletions(-) Approvals: Impala Public Jenkins: Verified Zoltan Borok-Nagy: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I71b47414321675958c05438ef3aeeb5df0128033 Gerrit-Change-Number: 22761 Gerrit-PatchSet: 6 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com>
