Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 21: (5 comments) http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py@1000 PS21, Line 1000: json_body = dict() The do_connection function was already 202 lines line before adding this OAuth code. Please consider moving the OAuth portion to its own function. http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py@1019 PS21, Line 1019: self.user Needs to be switched to using new client id parameter. http://gerrit.cloudera.org:8080/#/c/22424/16/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/16/tests/custom_cluster/test_shell_jwt_auth.py@207 PS16, Line 207: size=1) > In the case of mock response option, impala shell will not throw error if t It will error now that the client-id parameter is being used. Thus --client-id is required. http://gerrit.cloudera.org:8080/#/c/22424/18/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/18/tests/custom_cluster/test_shell_jwt_auth.py@261 PS18, Line 261: self._stop_impala_cluster() > Yes, through expected count we can achieve the negation case. Added two mor Done http://gerrit.cloudera.org:8080/#/c/22424/21/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/21/tests/custom_cluster/test_shell_jwt_auth.py@213 PS21, Line 213: test-user Let's use a different value here since "test-user" is the subject of the test JWT token. That will ensure the client-id is not accidentally being used as the user id but instead the user id is being read from the JWT. -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 21 Gerrit-Owner: gaurav singh <gsi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Thu, 10 Apr 2025 17:27:15 +0000 Gerrit-HasComments: Yes
