Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22667 )
Change subject: IMPALA-13886: Fix order of recursion for complex types for tuple caching ...................................................................... IMPALA-13886: Fix order of recursion for complex types for tuple caching Queries that use complex types fail with an IllegalStateException when running with tuple caching. The issue is that the logic for registering tuples is recursing in the wrong order. It processes the parent before moving on to the child, but the parent references tuple id's in the child and cannot be processed first. This switches the ordering so that the children are processed first. Testing: - Added a sanity check for complex types in TupleCacheTest Change-Id: I853c06e76422382c628850181e3c7e4fdf86efc2 Reviewed-on: http://gerrit.cloudera.org:8080/22667 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java 2 files changed, 12 insertions(+), 5 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I853c06e76422382c628850181e3c7e4fdf86efc2 Gerrit-Change-Number: 22667 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>