Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22761 )
Change subject: IMPALA-13932: Add file path and position-based duplicate check for IcebergMergeNode ...................................................................... Patch Set 1: Code-Review+2 (5 comments) Thanks for the quick fix! http://gerrit.cloudera.org:8080/#/c/22761/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22761/1//COMMIT_MSG@8 PS1, Line 8: IcebergMergeNode nit: title should be single line http://gerrit.cloudera.org:8080/#/c/22761/1/be/src/exec/iceberg-merge-node.cc File be/src/exec/iceberg-merge-node.cc: http://gerrit.cloudera.org:8080/#/c/22761/1/be/src/exec/iceberg-merge-node.cc@187 PS1, Line 187: auto file_path = delete_meta_evaluators_[0]->GetStringVal(previous_row_); : previous_row_file_path_ = : std::string(reinterpret_cast<const char*>(file_path.ptr), file_path.len); Would it be the same as? previous_row_file_path_ = std::string(previous_row_file_path_); http://gerrit.cloudera.org:8080/#/c/22761/1/be/src/exec/iceberg-merge-node.cc@293 PS1, Line 293: if (previous_row_file_pos_ != file_pos.val) { : return false; : } nit: fits single line http://gerrit.cloudera.org:8080/#/c/22761/1/be/src/exec/iceberg-merge-node.cc@296 PS1, Line 296: _ nit: underscore is not needed. http://gerrit.cloudera.org:8080/#/c/22761/1/be/src/exec/iceberg-merge-node.cc@303 PS1, Line 303: if (different) { : return false; : } : return true; nit: return !different; -- To view, visit http://gerrit.cloudera.org:8080/22761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I71b47414321675958c05438ef3aeeb5df0128033 Gerrit-Change-Number: 22761 Gerrit-PatchSet: 1 Gerrit-Owner: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 08 Apr 2025 15:01:51 +0000 Gerrit-HasComments: Yes
