Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22705 )
Change subject: IMPALA-13920: Allow running minicluster with Java 17 ...................................................................... Patch Set 14: (4 comments) http://gerrit.cloudera.org:8080/#/c/22705/13/bin/bootstrap_system.sh File bin/bootstrap_system.sh: http://gerrit.cloudera.org:8080/#/c/22705/13/bin/bootstrap_system.sh@275 PS13, Line 275: ubuntu sudo update-java-alternatives -l || true > This was run at line 233. Why does it need to be run again? this was just here for additional logging when its result depended on the result of java -version removing it as impala-config-java.sh depends only on env vars again http://gerrit.cloudera.org:8080/#/c/22705/13/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java File fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java: http://gerrit.cloudera.org:8080/#/c/22705/13/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@92 PS13, Line 92: restartKudu(true); > typo: shouldlshould -> should Done http://gerrit.cloudera.org:8080/#/c/22705/13/fe/src/test/java/org/apache/impala/customservice/KuduHMSIntegrationTest.java@93 PS13, Line 93: } > typo: repeated TODO? the TODO is no longer relevant here, removing it http://gerrit.cloudera.org:8080/#/c/22705/13/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/22705/13/fe/src/test/resources/hive-site.xml.py@29 PS13, Line 29: 'dfs.replication': '3' > Why guard this? Shouldn't it be valid for Java 8 too (and wouldn't contain agree, in the current state IMPALA_JAVA_TOOL_OPTIONS should be available when this is called -- To view, visit http://gerrit.cloudera.org:8080/22705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If58b64a21d14a4a55b12dfe9ea0b9c3d5fe9c9cf Gerrit-Change-Number: 22705 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 07:49:26 +0000 Gerrit-HasComments: Yes
