Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22626 )

Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................


Patch Set 10: Code-Review+2

(1 comment)

Carry +2.

http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py@533
PS9, Line 533:   def build_summary_table(self, summary, output):
> Why not import it at the beginning of the file? Doing it in the functions m
Done.
I can not make the same thing work for impala_beeswax.py and 
impala_connection.py.
Might need https://issues.apache.org/jira/browse/IMPALA-11980 work first.



--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Mar 2025 17:10:16 +0000
Gerrit-HasComments: Yes

Reply via email to