Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22661 )
Change subject: IMPALA-13894: Allow slow check in tuple cache correctness verification when file sizes differ ...................................................................... Patch Set 4: (1 comment) Thanks Michael for the review. http://gerrit.cloudera.org:8080/#/c/22661/3/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/22661/3/be/src/exec/tuple-cache-node.cc@221 PS3, Line 221: verify_status = TupleTextFileUtil::VerifyRows(dump_file_path, ref_file_path); > Why did these orders need to change? I would expect it to be mentioned in t The previous order wasn’t correct, causing the log to show the wrong one as the reference file. Swapping the order fixes the logging issue. Added commit message. https://github.com/apache/impala/blob/f8e2f2c7db80d244f829457773959e5466e8b93d/be/src/exec/tuple-text-file-util.h#L38 -- To view, visit http://gerrit.cloudera.org:8080/22661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I02e031410dac32d9df746201b156783a8b7d9a1a Gerrit-Change-Number: 22661 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 04 Apr 2025 20:22:34 +0000 Gerrit-HasComments: Yes
