Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22724 )
Change subject: IMPALA-13925: Deflake TestFrontendConnectionLimit ...................................................................... IMPALA-13925: Deflake TestFrontendConnectionLimit TestFrontendConnectionLimit is flaky after IMPALA-13907. The test randomly picks one impalad and create multiple clients to connect to that impalad. However, the test also limits --fe_service_threads=1. If the random impalad picked is the first impalad, any new client might not be able to connect because the default ImpalaTestSuite.hs2_client has open session to the first impalad after running SET ALL query. ImpalaTestSuite.beeswax_client does not seem to have this issue because it does not run any query at connect(). This patch attempt to deflake the test by skip the creation of all default impala clients. Added classmethod need_default_clients() that is overrideable by test classes that wish to skip default client creation. Filed IMPALA-13930 to improve ImpylaHS2Connection instantiation. Testing: Manually loop the tests for 20 times and pass all of them. Before this patch, the test can get stuck if looped less than that. Change-Id: I53c6760f5e3734397746b5a228345c9df38eabcb Reviewed-on: http://gerrit.cloudera.org:8080/22724 Reviewed-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Tested-by: Impala Public Jenkins <impala-public-jenk...@cloudera.com> --- M tests/common/impala_test_suite.py M tests/custom_cluster/test_frontend_connection_limit.py 2 files changed, 42 insertions(+), 26 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22724 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I53c6760f5e3734397746b5a228345c9df38eabcb Gerrit-Change-Number: 22724 Gerrit-PatchSet: 8 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
