Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22726 )
Change subject: POC IMPALA-13929: Make 'functional-query' the default workload in tests ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22726/1/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22726/1/tests/common/impala_test_suite.py@193 PS1, Line 193: See IMPALA-3947 for explanation about : # the effect of this. I think it is worth to elaborate this as method documentation. At least mention pytest.config.option.workload_exploration_strategy and explain how it will impact skipping decision. http://gerrit.cloudera.org:8080/#/c/22726/1/tests/common/impala_test_suite.py@1430 PS1, Line 1430: @classmethod : def exploration_strategy(cls): This should be better documented. At the very least, we should warn how to override get_workload() properly so that no test is mistakenly skipped forever like TestCatalogHMSFailures. http://gerrit.cloudera.org:8080/#/c/22726/1/tests/custom_cluster/test_catalog_hms_failures.py File tests/custom_cluster/test_catalog_hms_failures.py: http://gerrit.cloudera.org:8080/#/c/22726/1/tests/custom_cluster/test_catalog_hms_failures.py@157 PS1, Line 157: if cls.exploration_strategy() != 'exhaustive': : pytest.skip('These tests only run in exhaustive') Ideally, whole class skipping like this should be detected in ImpalaTestSuite.setup_class(). Let say we have classmethod ImpalaTestSuite.minimum_exploration_level() that is overridable by subclasses. @classmethod def minimum_exploration_level(cls): return 'core' In ImpalaTestSuite.setup_class(), we can centralize logging and skipping, like this pseudo code: if cls.exploration_strategy() < cls.minimum_exploration_level(): pytest.skip('This tests require exploration level {0}, but workload {1} is set with exploration level {2}'.format( cls.minimum_exploration_level(), cls.get_workload(), cls.exploration_strategy())) Note though that 'core' < 'pairwise' < 'exhaustive'. Although currently 'core' == 'pairwise' in our test framework. Please double check at test_vector.py. -- To view, visit http://gerrit.cloudera.org:8080/22726 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9ec6c41ffb3a30e1ea2de773626d1485c69fe115 Gerrit-Change-Number: 22726 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 17:39:41 +0000 Gerrit-HasComments: Yes
