Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22728 )
Change subject: IMPALA-13738 (Part2) WIP: Clean up code in Catalog's table and partition interfaces ...................................................................... Patch Set 2: (1 comment) I really like this cleanup, the code looks much better after this change. http://gerrit.cloudera.org:8080/#/c/22728/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22728/2/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@387 PS2, Line 387: public FeFsPartition loadPartition(long id) { In FeFsTable, now the 'loadPartitions(Collection<Long> ids)' method is the "base" abstract method, and loadPartition() and loadAllPartitions() are default-implemented in terms of that. Couldn't 'loadPartition(long id)' be the base abstract method, and FeFsTable could default-implement the other two methods with this. -- To view, visit http://gerrit.cloudera.org:8080/22728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8d9c7ba876e39fa4f4d067761f25dc4ecfd55702 Gerrit-Change-Number: 22728 Gerrit-PatchSet: 2 Gerrit-Owner: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 03 Apr 2025 13:57:08 +0000 Gerrit-HasComments: Yes
