Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22705 )
Change subject: IMPALA-13920: Allow running minicluster with Java 17 ...................................................................... Patch Set 18: (2 comments) http://gerrit.cloudera.org:8080/#/c/22705/16/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/22705/16/bin/run-all-tests.sh@322 PS16, Line 322: # Restore old (likely empty) JAVA_TOOL_OPTIONS to avoid polluting other tests. : export JAVA_TOOL_OPTIONS=$PREV_JAVA_TOOL_OPTIONS Sharing my struggles with this one: it turned out that setting JAVA_TOOL_OPTIONS here causes trouble later in custom cluster tests with Java17. The results are error like this: https://jenkins.impala.io/view/Ubuntu%2022/job/ubuntu-22.04-from-scratch-java17/41/testReport/junit/custom_cluster.test_catalog_hms_failures/TestHiveMetaStoreFailure/test_hms_service_dies/ the error comes when jps is called to help killing hive metastore by getting its pid I had the illusion of green tests, because as earlier only custom clusters were red, I started skipping the other tests during the runs, so the FE test block didn't set JAVA_TOOL_OPTIONS http://gerrit.cloudera.org:8080/#/c/22705/16/fe/pom.xml File fe/pom.xml: http://gerrit.cloudera.org:8080/#/c/22705/16/fe/pom.xml@26 PS16, Line 26: <version>5.0.0-SNAPSHOT</version> > Looks like your local branch was a bit out-of-date. thanks, done the rebase -- To view, visit http://gerrit.cloudera.org:8080/22705 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If58b64a21d14a4a55b12dfe9ea0b9c3d5fe9c9cf Gerrit-Change-Number: 22705 Gerrit-PatchSet: 18 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 17:24:05 +0000 Gerrit-HasComments: Yes
