Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22721 )
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables ...................................................................... Patch Set 3: (2 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h File be/src/exec/text-converter.inline.h: http://gerrit.cloudera.org:8080/#/c/22721/2/be/src/exec/text-converter.inline.h@105 PS2, Line 105: parse_result = StringParser::PARSE_FAILURE; : break; > optional: it would be clearer to extract the string parsing switch part of It should be possible, but we also need to keep WriteSlot() in sync with CodegenWriteSlot(), so I rather not change too many things here to keep the implementations similar. CodegenWriteSlot() is not supported for BINARY, so this change doesn't require changing CodegenWriteSlot(). http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test File testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test: http://gerrit.cloudera.org:8080/#/c/22721/2/testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test@29 PS2, Line 29: SELECT id, bindata FROM inval > This is the same as the first query in the test. Removed -- To view, visit http://gerrit.cloudera.org:8080/22721 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964 Gerrit-Change-Number: 22721 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 02 Apr 2025 16:04:29 +0000 Gerrit-HasComments: Yes
