Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22640 )

Change subject: IMPALA-13850 (part 2): Implement in-place reset for CatalogD
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22640/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/22640/8/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@4400
PS8, Line 4400:       resp.catalog_info.db_names = 
ImmutableList.copyOf(dbCache_.keySet());
> True. But similar like initial getCatalogDelta() scenario, how is it differ
What I want to say is, dbCache_ should be the sole source of truth at any time. 
Not the HMS response (getAllDatabases()) that has not been inspected/populated 
into dbCache_.



--
To view, visit http://gerrit.cloudera.org:8080/22640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4ae2154612746b34484391c5950e74b61f85c9d
Gerrit-Change-Number: 22640
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Anonymous Coward <k.venureddy2...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com>
Gerrit-Comment-Date: Tue, 01 Apr 2025 03:15:10 +0000
Gerrit-HasComments: Yes

Reply via email to