Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22698 )
Change subject: IMPALA-13909: Remove cursor fixture from custom_cluster/test_kudu.py ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/22698/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22698/1//COMMIT_MSG@10 PS1, Line 10: cursor fixture. nit: duplicate. http://gerrit.cloudera.org:8080/#/c/22698/1/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/22698/1/tests/custom_cluster/test_kudu.py@38 PS1, Line 38: # query to get number of rows. : _row_num_query = "select count(*) from {0}" Is it better to let this be a local variable within assert_num_row()? http://gerrit.cloudera.org:8080/#/c/22698/1/tests/custom_cluster/test_kudu.py@64 PS1, Line 64: Query number nit: "Assert query's number of rows" -- To view, visit http://gerrit.cloudera.org:8080/22698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046bf987dd16ecdf493d999e86191d85210f2de5 Gerrit-Change-Number: 22698 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Fri, 28 Mar 2025 15:39:24 +0000 Gerrit-HasComments: Yes
