Daniel Vanko has posted comments on this change. ( http://gerrit.cloudera.org:8080/22542 )
Change subject: IMPALA-12107: Throw AnalysisException for unsupported Kudu range-partioning types ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/22542/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22542/7//COMMIT_MSG@12 PS7, Line 12: Testing: : * add fe tests > Please create a separate ticket and patch about this. It's usually good pra Created IMPALA-13859 and implemented in https://gerrit.cloudera.org/c/22674/ http://gerrit.cloudera.org:8080/#/c/22542/7/fe/src/main/java/org/apache/impala/analysis/RangePartition.java File fe/src/main/java/org/apache/impala/analysis/RangePartition.java: http://gerrit.cloudera.org:8080/#/c/22542/7/fe/src/main/java/org/apache/impala/analysis/RangePartition.java@177 PS7, Line 177: Type colType = pkColumn.getTyp > This is already imported Done http://gerrit.cloudera.org:8080/#/c/22542/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test File testdata/workloads/functional-query/queries/QueryTest/kudu_create.test: http://gerrit.cloudera.org:8080/#/c/22542/7/testdata/workloads/functional-query/queries/QueryTest/kudu_create.test@690 PS7, Line 690: ---- RUNTIME_PROFILE > Please add tests about DECIMAL primary keys / range partitions, also with I added in the other change -- To view, visit http://gerrit.cloudera.org:8080/22542 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3e3037318065b0f4437045a7e8dbb76639404167 Gerrit-Change-Number: 22542 Gerrit-PatchSet: 9 Gerrit-Owner: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 26 Mar 2025 13:07:58 +0000 Gerrit-HasComments: Yes
