Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22671 )

Change subject: IMPALA-13893: Add node id to the file name in tuple cache 
correctness verification
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22671/1/be/src/exec/tuple-cache-node.cc
File be/src/exec/tuple-cache-node.cc:

http://gerrit.cloudera.org:8080/#/c/22671/1/be/src/exec/tuple-cache-node.cc@396
PS1, Line 396:   // For reference files, the name includes the current fragment 
instance node id, the original
line too long (95 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/22671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ce5ed05623761ace7b7a1027b762736a63e97fc
Gerrit-Change-Number: 22671
Gerrit-PatchSet: 1
Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Wed, 26 Mar 2025 00:03:00 +0000
Gerrit-HasComments: Yes

Reply via email to