Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/22306 )
Change subject: IMPALA-13653: Create hooks for Calcite planner in Frontend ...................................................................... Patch Set 21: Code-Review+1 (2 comments) This generally lgtm and it has already gone through reviews. Just a couple of comments. Doing a +1 for now. http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@91 PS21, Line 91: private final ParsedStatement parsedStmt_; nit: it would be good to add a comment here about why both ParsedStatement and StatementBase are needed. The latter is derivable from the former but it appears to be more as a convenience to minimize code changes. http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@106 PS21, Line 106: : null; Having a null value for stmt_ is not a good state as a lot of code dereferences this. Did you have this for specific reason ? In the Parser.java, the parse() method either returns a StatementBase object or it throws an exception. If nulls are not expected, it is best to add a precondition check. -- To view, visit http://gerrit.cloudera.org:8080/22306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978aa48b160984ee5d36244cd915940f838d141d Gerrit-Change-Number: 22306 Gerrit-PatchSet: 21 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 19:01:11 +0000 Gerrit-HasComments: Yes
