Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22658 )
Change subject: IMPALA-13889: Add assertion in TestWebPage::test_query_progress ...................................................................... Patch Set 3: > Patch Set 3: Code-Review+2 > > (1 comment) > > This issue seems like a timing issue where the query reaches the expected > state but the debug webpage does not get updated fast enough. > > Another technique to consider is that test_query_log.py does -- it waits for > the query status to update in the debug webpage. > https://github.com/apache/impala/blob/e73e2d40da115ed3804ffaecc0850c853b0e6330/tests/custom_cluster/test_query_log.py#L572-L577 Thanks! I initially thought so. But queries in this tests wait query handle to reach RUNNING state before getting the WebUI. And based on code in ClientRequestState::FinishExecQueryOrDmlRequest, it should not be possible for WebUI to lag behind. I'll monitor if it still flaky after this patch. -- To view, visit http://gerrit.cloudera.org:8080/22658 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b8bb768bb513c3055a83106511f5a6134a674a6 Gerrit-Change-Number: 22658 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Tue, 25 Mar 2025 23:03:25 +0000 Gerrit-HasComments: No
