Riza Suminto has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22626 )

Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................


Patch Set 6:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py
File shell/impala_client.py:

http://gerrit.cloudera.org:8080/#/c/22626/6/shell/impala_client.py@48
PS6, Line 48: from exec_summary import build_exec_summary_table
Looks like there is an import confusion going here. Here is one fail occurrence:

custom_cluster/test_client_keepalive.py:100: in test_ssl_keepalive
    self.check_keepalive(vector, ssl=True)
custom_cluster/test_client_keepalive.py:78: in check_keepalive
    result = run_impala_shell_cmd(vector, shell_options)
shell/util.py:137: in run_impala_shell_cmd
    result.stderr)
E   AssertionError: Cmd ['-q', 'shell sleep 1 && ss -Hton sport = 21000', 
'--ssl'] was expected to succeed: Traceback (most recent call last):
E     File "/usr/lib/python2.7/runpy.py", line 174, in _run_module_as_main
E       "__main__", fname, loader, pkg_name)
E     File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
E       exec code in run_globals
E     File 
"/home/ubuntu/Impala/shell/build/impala-shell-5.0.0-SNAPSHOT/install_py2.7/impala_shell/impala_shell.py",
 line 43, in <module>
E       from impala_client import ImpalaHS2Client, StrictHS2Client, \
E     File 
"/home/ubuntu/Impala/shell/build/impala-shell-5.0.0-SNAPSHOT/install_py2.7/impala_shell/impala_client.py",
 line 48, in <module>
E       from exec_summary import build_exec_summary_table
E   ImportError: No module named exec_summary

I'll try moving this inside build_summary_table function.



--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Comment-Date: Fri, 21 Mar 2025 14:54:09 +0000
Gerrit-HasComments: Yes

Reply via email to