Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22306 )
Change subject: IMPALA-13653: Create hooks for Calcite planner in Frontend ...................................................................... Patch Set 21: Code-Review+1 (3 comments) This is looking good to me http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@497 PS21, Line 497: //XXX: returnsAtMostOneRow should be in interface Let's file a JIRA for this. It's low priority as this seems like an edge case for result spooling. http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/ParsedStatementImpl.java File fe/src/main/java/org/apache/impala/analysis/ParsedStatementImpl.java: http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/analysis/ParsedStatementImpl.java@22 PS21, Line 22: import org.apache.impala.analysis.AnalysisContext.AnalysisDriverImpl; : import org.apache.impala.analysis.AnalysisContext.AnalysisResult; : import org.apache.impala.analysis.AnalysisDriver; : import org.apache.impala.analysis.Parser; : import org.apache.impala.analysis.QueryStmt; : import org.apache.impala.analysis.TableName; : import org.apache.impala.analysis.StatementBase; : import org.apache.impala.analysis.StmtMetadataLoader; : import org.apache.impala.authorization.AuthorizationFactory; : import org.apache.impala.common.ImpalaException; : import org.apache.impala.thrift.TQueryCtx; : import org.apache.impala.thrift.TQueryOptions; : import org.apache.impala.thrift.TResultSetMetadata; : import org.apache.impala.thrift.TStmtType; : : import static org.apache.impala.analysis.ToSqlOptions.SHOW_IMPLICIT_CASTS; Nit: Let's take a pass at cleaning up these imports (e.g. AnalysisDriverImpl, AnalysisResult, AuthorizationFactory, TResultSetMetadata, TStmtType, SHOW_IMPLICT_CASTS) http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22306/21/fe/src/main/java/org/apache/impala/service/Frontend.java@3522 PS21, Line 3522: private CompilerFactory getCompilerFactory(PlanCtx ctx) { : return new CompilerFactoryImpl(); : } Nit: I think this is unused now -- To view, visit http://gerrit.cloudera.org:8080/22306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I978aa48b160984ee5d36244cd915940f838d141d Gerrit-Change-Number: 22306 Gerrit-PatchSet: 21 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Mar 2025 20:56:19 +0000 Gerrit-HasComments: Yes
