Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22353 )
Change subject: IMPALA-13586: Initial support for Iceberg REST Catalogs ...................................................................... Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/22353/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java File fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java: http://gerrit.cloudera.org:8080/#/c/22353/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java@48 PS1, Line 48: IcebergRESTCatalog > This comment lost in PS1 :) Ah, sorry. In the Iceberg library they also use full capital for REST, and in this director we typically just prefix the Iceberg classes with "Iceberg", e.g. HadoopCatalog -> IcebergHadoopCatalog. So I'd lean towards keeping it as is. http://gerrit.cloudera.org:8080/#/c/22353/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java@49 PS1, Line 49: private final static Logger LOG = LoggerFactory.getLogger(IcebergRESTCatalog.class); > nit: unused Done http://gerrit.cloudera.org:8080/#/c/22353/1/fe/src/main/java/org/apache/impala/catalog/iceberg/IcebergRESTCatalog.java@116 PS1, Line 116: Map<String, String> properties) throws IcebergTableLoadingException { > line too long (94 > 90) Done http://gerrit.cloudera.org:8080/#/c/22353/14/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java File fe/src/main/java/org/apache/impala/service/FeCatalogManager.java: http://gerrit.cloudera.org:8080/#/c/22353/14/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java@228 PS14, Line 228: > line too long (108 > 90) Done http://gerrit.cloudera.org:8080/#/c/22353/14/fe/src/main/java/org/apache/impala/service/FeCatalogManager.java@231 PS14, Line 231: > line too long (91 > 90) Done -- To view, visit http://gerrit.cloudera.org:8080/22353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1722b898b568d2f5689002f2b9bef59320cb088c Gerrit-Change-Number: 22353 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Noemi Pap-Takacs <npaptak...@cloudera.com> Gerrit-Reviewer: Peter Rozsa <pro...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Mar 2025 12:17:46 +0000 Gerrit-HasComments: Yes
