Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22617 )
Change subject: IMPALA-13861: Standardize workload management tests ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/22617/5/tests/custom_cluster/test_query_live.py File tests/custom_cluster/test_query_live.py: http://gerrit.cloudera.org:8080/#/c/22617/5/tests/custom_cluster/test_query_live.py@79 PS5, Line 79: actual_hosts.remove(host) > There is still the potential for brittle tests. Take, for example, lines 8 Ok, setting long --query_log_write_interval_s for most test method and undo WorkloadManagementTestSuite extension. Done. http://gerrit.cloudera.org:8080/#/c/22617/5/tests/custom_cluster/test_workload_mgmt_init.py File tests/custom_cluster/test_workload_mgmt_init.py: http://gerrit.cloudera.org:8080/#/c/22617/5/tests/custom_cluster/test_workload_mgmt_init.py@363 PS5, Line 363: additional_impalad_opts="--minidump_path={}".format(tmp_dir)) > Interesting. We have a C++ style guide that lays out the 4 space requireme Done http://gerrit.cloudera.org:8080/#/c/22617/5/tests/custom_cluster/test_workload_mgmt_init.py@377 PS5, Line 377: additional_catalogd_opts="--workload_mgmt_drop_tables={}".format( > flake8 and autopep8 agree with this. Done -- To view, visit http://gerrit.cloudera.org:8080/22617 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecf6452fa963304e263805ebeb017c843d17dd16 Gerrit-Change-Number: 22617 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Sat, 15 Mar 2025 05:05:24 +0000 Gerrit-HasComments: Yes
