Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/22215 )
Change subject: IMPALA-13478: Sync tuple cache files to disk asynchronously ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22215/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22215/4//COMMIT_MSG@9 PS4, Line 9: When a tuple cache entry is first being written, we want to I recall hearing that the data cache currently does not sync files. If that is true, is there a reason to sync tuple cache files. I can understand this being required later to support results shared over a network but we should not incur sync costs unless they are needed. -- To view, visit http://gerrit.cloudera.org:8080/22215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646bb56300656d8b8ac613cb8fe2f85180b386d3 Gerrit-Change-Number: 22215 Gerrit-PatchSet: 4 Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Fri, 14 Mar 2025 17:52:16 +0000 Gerrit-HasComments: Yes