Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22626 )

Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary
......................................................................


Patch Set 1:

(6 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py
File tests/common/impala_connection.py:

http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: s
flake8: U100 Unused argument 'sql_stmt'


http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: u
flake8: U100 Unused argument 'user'


http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@290
PS1, Line 290: f
flake8: U100 Unused argument 'fetch_profile_after_close'


http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@291
PS1, Line 291: f
flake8: U100 Unused argument 'fetch_exec_summary'


http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@291
PS1, Line 291: p
flake8: U100 Unused argument 'profile_format'


http://gerrit.cloudera.org:8080/#/c/22626/1/tests/common/impala_connection.py@391
PS1, Line 391: o
flake8: U100 Unused argument 'operation_handle'



--
To view, visit http://gerrit.cloudera.org:8080/22626
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6
Gerrit-Change-Number: 22626
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Comment-Date: Fri, 14 Mar 2025 00:27:14 +0000
Gerrit-HasComments: Yes

Reply via email to