Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... Patch Set 7: Code-Review+1 (2 comments) > Patch Set 7: > > (2 comments) I did not realize, TestStringValue would not print the call stack. Thank you for describing it with a comment. http://gerrit.cloudera.org:8080/#/c/22588/5/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22588/5/be/src/exprs/ai-functions.cc@71 PS5, Line 71: const ::impala::Status& _status = (stmt); \ : if (UNLIKELY(!_status.ok())) { \ : SET_ERROR(ctx, _status.msg().msg(), AI_GENERATE_TXT_COMMON_ERROR_PREFIX); \ : return StringVal::null(); \ : } > It makes sense. Changed to string. Done. http://gerrit.cloudera.org:8080/#/c/22588/5/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: http://gerrit.cloudera.org:8080/#/c/22588/5/be/src/exprs/expr-test.cc@11395 PS5, Line 11395: + AiFunctions::AI_GENERATE_TXT_COMMON_ERROR_PREFIX.size(); : size_t override_forbidden_error_len = : AiFunctions::AI_GENERATE_TXT_MSG_OVERRIDE_FORBIDDEN_ERROR.size() : + AiFunctions::AI_GENERATE_TXT_COMMON_ERROR_PREFIX.size(); : size_t n_override_forbidden_error_len = : AiFunctions::AI_GENERATE_TXT_N_OVERRIDE_FORBIDDEN_ERROR.size() : + AiFunctions::AI_GENERATE_TXT_COMMON_ERROR_PREFIX.size(); : // Test override/additional params : // invalid json results in error. : StringVal invalid_json_params("{\"temperature\": 0.49, \ > Currently, I don't think TestStringValue() prints the call stack, for examp Done. -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 7 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 13 Mar 2025 16:46:36 +0000 Gerrit-HasComments: Yes
