Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22527 )
Change subject: WIP: add ipv6 support for webui/hs2/hs2-http/beeswax ...................................................................... Patch Set 14: (3 comments) http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/rpc/thrift-server.h File be/src/rpc/thrift-server.h: http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/rpc/thrift-server.h@348 PS6, Line 348: /// The host name to with the server interface. A comment here would be nice. What's the usual format of host, an IP address or hostname? http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/CMakeLists.txt File be/src/util/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/22527/6/be/src/util/CMakeLists.txt@167 PS6, Line 167: nit: whitespace http://gerrit.cloudera.org:8080/#/c/22527/14/tests/common/impala_test_suite.py File tests/common/impala_test_suite.py: http://gerrit.cloudera.org:8080/#/c/22527/14/tests/common/impala_test_suite.py@275 PS14, Line 275: ImpalaTestSuite.impalad_test_service = cls.impalad_test_service What does this do? -- To view, visit http://gerrit.cloudera.org:8080/22527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ac66c568cc9bb06f4a3915db07a53c100109b6 Gerrit-Change-Number: 22527 Gerrit-PatchSet: 14 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: gaurav singh <gsi...@cloudera.com> Gerrit-Comment-Date: Wed, 12 Mar 2025 20:23:18 +0000 Gerrit-HasComments: Yes
