Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 37: (2 comments) http://gerrit.cloudera.org:8080/#/c/21762/35//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21762/35//COMMIT_MSG@25 PS35, Line 25: or > nit: or Done http://gerrit.cloudera.org:8080/#/c/21762/35/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21762/35/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@805 PS35, Line 805: * impala.admission-control.max-query-mem-limit.<pool_name> set in llama file. : */ : public void setPoolMemLimit(TExecutorGroupSet groupSet) { : Preconditions.checkNotNull(groupSet); : // Only respect max_mem_limit from groupSet if RequestPoolService is configured : // (fair_scheduler_allocation_path flag is not empty) and : // impala.admission-control.clamp-mem-limit-query-option.<pool_name> is True and : // impala.admission-control.max-query-mem-limit.<pool_name> is set. : > I think the logic needs to be updated because it's being used for both mem_ Done -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 37 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Becker <daniel.bec...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 10 Mar 2025 22:04:57 +0000 Gerrit-HasComments: Yes
