Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22603 )
Change subject: WIP IMPALA-10349: Support constant folding for non ascii strings ...................................................................... Patch Set 1: (6 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22603/1/common/thrift/Exprs.thrift File common/thrift/Exprs.thrift: http://gerrit.cloudera.org:8080/#/c/22603/1/common/thrift/Exprs.thrift@119 PS1, Line 119: 1: required binary value; Changing type of field 'value' from string to binary in TStringLiteral might break the compatibility between impalad and catalogd/statestore during upgrade http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java File fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java: http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/main/java/org/apache/impala/analysis/LiteralExpr.java@199 PS1, Line 199: * Returns null for types that do not have a LiteralExpr subclass, line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java File fe/src/main/java/org/apache/impala/analysis/StringLiteral.java: http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@111 PS1, Line 111: byte[] val = (needsUnescaping_) ? StandardCharsets.UTF_8.encode(getUnescapedValue()).array() : binValue_; line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/main/java/org/apache/impala/analysis/StringLiteral.java@259 PS1, Line 259: if (binValue_[i] < other.binValue_[i]) return 1; line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java File fe/src/test/java/org/apache/impala/service/JniFrontendTest.java: http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@138 PS1, Line 138: TStringLiteral secretKey = new TStringLiteral(StandardCharsets.UTF_8.encode("openai-api-key-secret")); line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/22603/1/fe/src/test/java/org/apache/impala/service/JniFrontendTest.java@143 PS1, Line 143: line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22603 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I70663457a0b0a3443e586350f0a5996bb75ba64a Gerrit-Change-Number: 22603 Gerrit-PatchSet: 1 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Sun, 09 Mar 2025 22:50:47 +0000 Gerrit-HasComments: Yes
