Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh File docker/install_os_packages.sh: http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh@128 PS1, Line 128: elif [[ -f /sbin/apk && -x /sbin/apk ]]; then : echo "Indentified Wolfi-based system." > It was essentially a compromise. I've decided to remove the extra check for apk: better to be conservative on which images are accepted as base images. http://gerrit.cloudera.org:8080/#/c/22583/1/docker/install_os_packages.sh@135 PS1, Line 135: echo "Only Ubuntu and Redhat-based distributions, or Chainguard/Wolfi base images are supported." > line too long (99 > 90) Ack -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Daniel Vanko <dva...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Laszlo Gaal <laszlo.g...@cloudera.com> Gerrit-Comment-Date: Thu, 06 Mar 2025 20:35:36 +0000 Gerrit-HasComments: Yes
